[Webkit-unassigned] [Bug 109665] Stroked patterns paint even when object bounding box is empty

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 13 14:29:23 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109665


Florin Malita <fmalita at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |fmalita at chromium.org
                   |kit.org                     |




--- Comment #3 from Florin Malita <fmalita at chromium.org>  2013-02-13 14:31:39 PST ---
I think I see the problem.

The empty object bounding box logic kicks in only when patternUnits == SVG_UNIT_TYPE_OBJECTBOUNDINGBOX:

    if (m_attributes.patternUnits() == SVGUnitTypes::SVG_UNIT_TYPE_OBJECTBOUNDINGBOX && objectBoundingBox.isEmpty())
        return false;

But we are making this decision before updating patternUnits from the element, so we're always seeing SVG_UNIT_TYPE_OBJECTBOUNDINGBOX on the first pass! Later, when the second line gets painted, the pattern attributes get collected and patternUnits is updated to the specified SVG_UNIT_TYPE_USERSPACEONUSE. Then on subsequent repaints the empty bounding box logic no longer kicks in because attributes are up to date.

I'll get a patch up tomorrow.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list