[Webkit-unassigned] [Bug 109709] New: wtf/dota/* is copying Vectors all over the place

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109709

           Summary: wtf/dota/* is copying Vectors all over the place
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: darin at apple.com, abarth at webkit.org,
                    jochen at chromium.org, haraken at chromium.org


wtf/dota/* is copying Vectors all over the place

I suspect this code was ported from stl.  In WTF, Vector<T> as an argument will copy the whole contents of the vector, so we normally use const Vector<T>&

grep -r "(Vector" * | grep -v '&'
wtf/dtoa/bignum.cc:    static uint64_t ReadUInt64(Vector<const char> buffer,
wtf/dtoa/bignum.cc:    void Bignum::AssignDecimalString(Vector<const char> value) {
wtf/dtoa/bignum.cc:    void Bignum::AssignHexString(Vector<const char> value) {
wtf/dtoa/bignum.h:        void AssignDecimalString(Vector<const char> value);
wtf/dtoa/bignum.h:        void AssignHexString(Vector<const char> value);
wtf/dtoa/double-conversion.cc:        double converted = Strtod(Vector<const char>(buffer, buffer_pos), exponent);
wtf/dtoa/fast-dtoa.cc:    static bool RoundWeed(Vector<char> buffer,
wtf/dtoa/fast-dtoa.cc:    static bool RoundWeedCounted(Vector<char> buffer,
wtf/dtoa/fixed-dtoa.cc:    static void RoundUp(Vector<char> buffer, int* length, int* decimal_point) {
wtf/dtoa/fixed-dtoa.cc:    static void TrimZeros(Vector<char> buffer, int* length, int* decimal_point) {
wtf/dtoa/strtod.cc:    static Vector<const char> TrimLeadingZeros(Vector<const char> buffer) {
wtf/dtoa/strtod.cc:    static Vector<const char> TrimTrailingZeros(Vector<const char> buffer) {
wtf/dtoa/strtod.cc:    static void TrimToMaxSignificantDigits(Vector<const char> buffer,
wtf/dtoa/strtod.cc:    static uint64_t ReadUint64(Vector<const char> buffer,
wtf/dtoa/strtod.cc:    static void ReadDiyFp(Vector<const char> buffer,
wtf/dtoa/strtod.cc:    static bool DoubleStrtod(Vector<const char> trimmed,
wtf/dtoa/strtod.cc:    static bool DiyFpStrtod(Vector<const char> buffer,
wtf/dtoa/strtod.cc:    static double BignumStrtod(Vector<const char> buffer,
wtf/dtoa/strtod.cc:    double Strtod(Vector<const char> buffer, int exponent) {
wtf/dtoa/strtod.cc:            return Strtod(Vector<const char>(significant_buffer,
wtf/dtoa/strtod.h:    double Strtod(Vector<const char> buffer, int exponent);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.