[Webkit-unassigned] [Bug 108892] Passing alpha to DeferredImageDecoder once decoding completes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 21:32:29 PST 2013


--- Comment #10 from Hin-Chung Lam <hclam at google.com>  2013-02-12 21:34:43 PST ---
(From update of attachment 187898)
View in context: https://bugs.webkit.org/attachment.cgi?id=187898&action=review

> Source/WebCore/platform/graphics/chromium/DeferredImageDecoder.cpp:186
> +        return pixelRef->frameGenerator()->hasAlpha();

DeferredImageDecoder already has a pointer to ImageFrameGenerator.

> Source/WebCore/platform/graphics/chromium/ImageFrameGenerator.h:70
> +    bool hasAlpha() const { return m_hasAlpha; }

This is not thread-safe and we need a lock for reading and writing to this value.

You don't want to acquire the decodeMutex.. so I guess it's fine to have a alphaMutex (reluctantly..)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list