[Webkit-unassigned] [Bug 109560] Implement coordinated scrollbar for subframes and sublayers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 12:57:17 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109560





--- Comment #5 from Tien-Ren Chen <trchen at chromium.org>  2013-02-12 12:59:31 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 187822 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=187822&action=review
> > 
> > r- for abuse of setContentsToMedia.
> > 
> > > Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:125
> > > +    scrollbarGraphicsLayer->setContentsToMedia(scrollbarLayer->layer());
> > 
> > This seems like an abuse of setContentsToMedia.
> 
> I consider coordinated scrollbar to be a built-in plug-in provided by chromium compositor. Anyway we need to find some way to attach customized platform layer to a GraphicsLayer. What are the other choices that is less abusive?

Per off-line discussion with aelias@, we think we should make a GraphicsLayerChromium::setContentsToCoordinatedScrollbar extension. Does that sound cleaner?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list