[Webkit-unassigned] [Bug 109560] Implement coordinated scrollbar for subframes and sublayers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 09:08:42 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109560


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187822|review?                     |review-
               Flag|                            |




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-02-12 09:10:55 PST ---
(From update of attachment 187822)
View in context: https://bugs.webkit.org/attachment.cgi?id=187822&action=review

r- for abuse of setContentsToMedia.

> Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:125
> +    scrollbarGraphicsLayer->setContentsToMedia(scrollbarLayer->layer());

This seems like an abuse of setContentsToMedia.

> Source/WebCore/rendering/RenderLayerBacking.cpp:1015
>      if (needsHorizontalScrollbarLayer) {
>          if (!m_layerForHorizontalScrollbar) {
>              m_layerForHorizontalScrollbar = createGraphicsLayer("horizontal scrollbar");
>              layersChanged = true;
> +            if (scrollingCoordinator)
> +                scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_owningLayer, HorizontalScrollbar);
>          }
>      } else if (m_layerForHorizontalScrollbar) {
>          m_layerForHorizontalScrollbar.clear();
>          layersChanged = true;
> +        if (scrollingCoordinator)
> +            scrollingCoordinator->scrollableAreaScrollbarLayerDidChange(m_owningLayer, HorizontalScrollbar);

I'd prefer that you change the code so that you only need to call scrollableAreaScrollbarLayerDidChange in one or two places in this function, not 4 times.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list