[Webkit-unassigned] [Bug 92868] [css3-text] Add platform support for "wavy" text decoration style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92868





--- Comment #34 from Lamarque V. Souza <Lamarque.Souza at basyskom.com>  2013-02-12 04:15:21 PST ---
(In reply to comment #33)
> (In reply to comment #32)
> > (From update of attachment 186394 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=186394&action=review
> > > Source/WebCore/ChangeLog:14
> > > +        Tests are in
> > > +        fast/css3-text/css3-text-decoration/text-decoration-style.html already,
> > > +        just need to rebaseline them (see bug 100546).
> > 
> > Then when not already rebaseline them for your platform in this patch?
> 
> Ok, I will do it.

I have noticed that my other patch for https://bugs.webkit.org/show_bug.cgi?id=93507 already includes the baseline for my platform. We will have to revert that other patch to include the baseline in this patch.

> > As an alternative, why not 'strokeWavyTextDecoration(GraphicsContext* context, const FloatPoint& point1, const FloatPoint& point2)'?
> > 
> > +don't const the input float;
> 
> Why not const them?

By the way, if I do not const them then I cannot write

strokeWavyTextDecoration(context, FloatPoint(localOrigin.x(), localOrigin.y() + baseline + doubleOffset + 1), FloatPoint(localOrigin.x() + width, localOrigin.y() + baseline + doubleOffset + 1), textDecorationThickness);

in InlineTextBox::paintDecoration(). I would have to create a temporary variable for each FloatPoint parameter before passing them to strokeWavyTextDecoration().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.