[Webkit-unassigned] [Bug 109284] Web Inspector: for event listener provide handler function value in protocol and in UI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 01:35:15 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109284


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187641|review?                     |review+
               Flag|                            |




--- Comment #8 from Yury Semikhatsky <yurys at chromium.org>  2013-02-12 01:37:28 PST ---
(From update of attachment 187641)
View in context: https://bugs.webkit.org/attachment.cgi?id=187641&action=review

> Source/WebCore/inspector/Inspector.json:1759
> +                    { "name": "handler", "$ref": "Runtime.RemoteObject", "optional": true, "description": "Event handler function value" }

Missing . at the end of the sentence.

> Source/WebCore/inspector/InspectorDOMAgent.h:134
> +    virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String*, RefPtr<TypeBuilder::Array<TypeBuilder::DOM::EventListener> >& listenersArray);

Param name would make sense here, otherwise it is hard to guess that the string param is objectGroupId

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list