[Webkit-unassigned] [Bug 105348] XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 15:17:35 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=105348





--- Comment #9 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2013-02-11 15:19:48 PST ---
The patch may be safe. The reason I paniced and put cq- on it is just to get time to review it tomorrow. The code here was the subject of a large number of race-conditions, and your patch also conflicts a little with comment below it:
// m_deferEvents is kept true until all deferred events have been dispatched.

The problem with resume is that a number of active DOM objects can be resumed at the same time, and the request here can both be cancelled or even suspended again before it has a chance to fully react to resume.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list