[Webkit-unassigned] [Bug 108513] [Chromium] Replace correct misspelled range

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108513





--- Comment #28 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-02-11 11:07:13 PST ---
(In reply to comment #27)
> (From update of attachment 187380 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187380&action=review
> 
> >>> Source/WebKit/chromium/src/WebFrameImpl.cpp:1316
> >>> +    if (!frame()->selection()->shouldChangeSelection(markerRange.get()))
> >> 
> >> Doesn't this break spellchecking inside a contenteditable element?
> > 
> > This patch adds a test that uses <div contentEditable></div> for spellcheck. I don't think it breaks anything.
> 
> Does it work even if you had content (e.g. some text) before div?

Spellcheck works with that use-case both pre-patch and post-patch: spellcheck suggests a correctly-spelled word and lets you replace the word within the element. The replacement behavior changes because the patch turns off smart-replace, but I expect that.

I've tested pre-patch and post-patch spellcheck for the following URL:

data:text/html,<span contentEditable>well</span><span contentEditable>come</span> home

Most behavior does not change:

1) The text fragments "well" and "come" are treated as one misspelled word "wellcome".

2) Context-click on "well" selects only "well" and suggests "welcome" as correct spelling.

3) Context-click on "come" selects only "come" and suggest "welcome" as correct spelling.

The behavior that changes is due to turning off smart-replace in the patch:

BEFORE the patch: If you select "welcome" suggestion from context menu, you would get either "welcome come" or "well welcome", depending on whether you context clicked on "well" or "come" part of the word.

AFTER the patch: If you select "welcome" suggestion from context menu, you would get either "welcomecome" or "wellwelcome", depending on whether you context clicked on "well" or "come" part of the word.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.