[Webkit-unassigned] [Bug 93214] [EFL][DRT] http/tests/loading/307-after-303-after-post.html times out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 10:35:04 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=93214





--- Comment #13 from youenn fablet <youennf at gmail.com>  2013-02-11 10:37:15 PST ---
> Perhaps it makes sense to unskip this test on GTK+ as well?


On GTK+, there is a bug in the DRT that prevents printing the expected output 
(https://bugs.webkit.org/show_bug.cgi?id=35300)
Once this bug is solved, it should be fine to unskip it.

> The first line should be the bug title and then the description should go underneath.

I will change this when reposting the patch.


> Hrm. Shouldn't this restore the original method instead of just unconditionally using GET? In any case, why not roll this into shouldRedirectAsGET?

It's right that the check is a bit loose.
In theory, we should check equality of the methods only if the soup request is a GET. But in practice for HTTP, the methods will be different only if a redirect enforces the verb to go from value to GET.
Should it be tightened?

Concerning shouldRedirectAsGET, the test was included in the previous patch.
I received the feedback that it would be better to decouple the pure http logic (implemented in shouldRedirectAsGET) from this test which is related to the implementation strategy (always start from the original request).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list