[Webkit-unassigned] [Bug 108513] [Chromium] Replace correct misspelled range

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108513





--- Comment #25 from Rouslan Solomakhin <rouslan+webkit at chromium.org>  2013-02-11 09:48:40 PST ---
(In reply to comment #24)
> (From update of attachment 187380 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187380&action=review
> 
> > Source/WebKit/chromium/src/WebFrameImpl.cpp:1316
> > +    RefPtr<Range> markerRange = Range::create(caretRange->ownerDocument(), caretRange->startContainer(), markers[0]->startOffset(), caretRange->endContainer(), markers[0]->endOffset());
> > +    if (!markerRange)
> > +        return;
> > +    if (!frame()->selection()->shouldChangeSelection(markerRange.get()))
> 
> Doesn't this break spellchecking inside a contenteditable element?

This patch adds a test that uses <div contentEditable></div> for spellcheck. I don't think it breaks anything.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.