[Webkit-unassigned] [Bug 108960] [GTK] Remove subresource leaks from WebKit1 and WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 11 08:46:57 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=108960





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-02-11 08:49:10 PST ---
(In reply to comment #9)
> (In reply to comment #7)
> 
> > For webkit1 we can do the same, but returning NULL from get_subresources() and marking it as deprecated in favor of a new save() method similar to the wk2 one.
> 
> It seems that in WebKit there's a getSubresources method we can call on the DocumentLoader.

If the document loader is caching the subresources, the problem is still there, no?

> We'll likely use this and create new WebKitWebResources during calls to get_subresources. The resource load signals will work as usual, but the actual WebKitWebResource will change for a given WebCore resource upon calling get_subresources, since once a load finishes we'll deref the original WebKitWebResources.

I'm not sure I understand this, we would create different WebKitWebResource objects, one to wrap the resource while loading to pass it to the signals and a different one to return in get_subresources. The former would be owned by webkit and released when the resource load finishes while the latter would be owned by the caller and not cached by webkit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list