[Webkit-unassigned] [Bug 108960] [GTK] Remove subresource leaks from WebKit1 and WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108960





--- Comment #10 from Martin Robinson <mrobinson at webkit.org>  2013-02-11 07:51:02 PST ---
(In reply to comment #8)
> (In reply to comment #6)
> > WebKit2 may only be leaking the URIResponse, but get_subresources still seems to have the chance to return responses for old or invalid data (and the responses still seem to be leaked).
> 
> why only the URI response? everytime a resource load starts it's added to the loading resources map and when it finishes, it's moved to the subresources map. So all the resources are kept in memory, not only the responses. I guess I'm missing something.

Hrm. I guess I meant the WebCore resource. The map stores a list of WebKitWebResources which only store a reference to the WebKitURIResponse. To get the data we call WebFrameProxy::getResourceData. I figured that we weren't actually maintaining a reference to the original resource in this case. I may be misunderstanding the code though.

This brings up the question of what happens when two of the resources have the same URL, but different data though...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.