[Webkit-unassigned] [Bug 109354] RenderText::isAllCollapsibleWhitespace() shouldn't upconvert string to 16-bit.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 10 16:22:30 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=109354
--- Comment #4 from Benjamin Poulain <benjamin at webkit.org> 2013-02-10 16:24:41 PST ---
(From update of attachment 187429)
View in context: https://bugs.webkit.org/attachment.cgi?id=187429&action=review
> Source/WebCore/rendering/RenderText.cpp:1193
> + for (unsigned i = 0; i < textLength(); i++) {
> + if (!style()->isCollapsibleWhiteSpace(characterAt(i)))
I would store textLength() in a temporary variable.
You may want to split this in 2 cases, 8bits and 16bits, instead of doing that in the loop.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list