[Webkit-unassigned] [Bug 109285] [Curl] setCookiesFromDOM function does not save cookies to disk.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109285


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187292|review?                     |review-
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2013-02-08 09:17:00 PST ---
(From update of attachment 187292)
View in context: https://bugs.webkit.org/attachment.cgi?id=187292&action=review

Very nice update.  Please switch to an "early return" style for that one method, since no other actions are taken in the case where the CURL handle is null.

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:37
> +    if (curl) {

Please make this an early return, since we do nothing if the curl interface is not present.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.