[Webkit-unassigned] [Bug 109284] Web Inspector: for event listener provide handler function value in protocol and in UI
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 8 05:29:50 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=109284
Yury Semikhatsky <yurys at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #187293|review? |review-
Flag| |
--- Comment #2 from Yury Semikhatsky <yurys at chromium.org> 2013-02-08 05:31:59 PST ---
(From update of attachment 187293)
View in context: https://bugs.webkit.org/attachment.cgi?id=187293&action=review
> Source/WebCore/bindings/v8/ScriptEventListener.cpp:112
> + V8AbstractEventListener* v8Listener = static_cast<V8AbstractEventListener*>(listener);
Please extract common part with eventListenerHandlerBody into a separate function.
> Source/WebCore/inspector/Inspector.json:1748
> + { "name": "handler", "$ref": "Runtime.RemoteObject", "optional": true, "hidden": true, "description": "Event handler function value" }
The type is already hidden.
> Source/WebCore/inspector/Inspector.json:1870
> + { "name": "objectGroup", "type": "string", "optional": true, "description": "Symbolic group name for handler value." }
Please add a note on that handler won't be returned if the group is not specified.
> Source/WebCore/inspector/InspectorDOMAgent.cpp:1394
> + InjectedScript injectedScript = m_injectedScriptManager->injectedScriptFor(mainWorldScriptState(frame));
You should use the world from event listener instead.
> Source/WebCore/inspector/front-end/EventListenersSidebarPane.js:123
> + node.eventListeners("arabypaC", callback);
Please use WebInspector.EventListenersSidebarPane._objectGroupName
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list