[Webkit-unassigned] [Bug 109011] File upload control doesn't apply CSS vertical padding or border to file name

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 04:12:50 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109011





--- Comment #12 from Nils Barth <nbarth at google.com>  2013-02-08 04:14:59 PST ---
(In reply to comment #11)
> > > Should we add "const" to variables like LayoutUnit textY etc.?
> > > (They're just set once.)
> > 
> > You should not add it in this patch because it is unrelated to the bug.
> 
> Furthermore, this is not something we do per WebKit coding style (as an unwritten rule, I guess).

Thanks for explaining; I was a bit puzzled about use of const in WebKit (my understanding was that it was generally avoided for some types, like String, but included for others). I'd noticed:
 const String& displayedFilename = fileTextValue();
 const Font& font = style()->font();
directly above, so I was wondering about it.

But understood -- generally don't use const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list