[Webkit-unassigned] [Bug 109268] [v8] isolate parameter added to all v8::peristent calls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 00:40:08 PST 2013


--- Comment #4 from Dan Carney <dcarney at google.com>  2013-02-08 00:42:16 PST ---
(In reply to comment #3)
> (From update of attachment 187256 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=187256&action=review
> > Source/WebCore/bindings/v8/NPV8Object.cpp:95
> > +    v8NpObject->v8Object.Dispose(v8::Isolate::GetCurrent());
> Can we avoid calling Isolate::GetCurrent() by passing an Isolate around?

I'll see if any of these are easily fixable now, but we are going to remove all instances of GetCurrent() in followup patches, so there is no need for 100s or FIXMEs throughout the code.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list