[Webkit-unassigned] [Bug 109268] [v8] isolate parameter added to all v8::peristent calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109268





--- Comment #3 from Kentaro Hara <haraken at chromium.org>  2013-02-08 00:34:11 PST ---
(From update of attachment 187256)
View in context: https://bugs.webkit.org/attachment.cgi?id=187256&action=review

> Source/WebCore/bindings/v8/NPV8Object.cpp:95
> +    v8NpObject->v8Object.Dispose(v8::Isolate::GetCurrent());

Can we avoid calling Isolate::GetCurrent() by passing an Isolate around?

> Source/WebCore/bindings/v8/NPV8Object.cpp:169
> +    v8npObject->v8Object = v8::Persistent<v8::Object>::New(v8::Isolate::GetCurrent(), object);

Ditto.

> Source/WebCore/bindings/v8/ScheduledAction.cpp:57
> +    v8::Isolate* isolate = context->GetIsolate();

Nit: context => m_context (just for consistency)

> Source/WebCore/bindings/v8/ScopedPersistent.h:46
> +        : m_handle(v8::Persistent<T>::New(v8::Isolate::GetCurrent(), handle))

This would be OK.

> Source/WebCore/bindings/v8/ScopedPersistent.h:60
>      void set(v8::Handle<T> handle)

This should receive an Isolate. If call sites are too many, you can fix it in a follow-up patch (please just add FIXME).

> Source/WebCore/bindings/v8/ScopedPersistent.h:77
> +        m_handle.Dispose(v8::Isolate::GetCurrent());

Ditto.

> Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp:76
> +    return v8::Persistent<v8::String>::New(v8::Isolate::GetCurrent(), v8::String::NewSymbol(key));

I think this can be fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.