[Webkit-unassigned] [Bug 108482] [WebCore][Notifications] Do not assume the page has a NotificationClient

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 07:54:38 PST 2013


--- Comment #8 from Jon Lee <jonlee at apple.com>  2013-02-07 07:56:46 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > Actually, doesn't it make more sense to not call provideNotification(), and check for the existence of a controller?
> Actually the caller of Notification::requestPermission() seems to be JSNotification::requestPermission(). Not sure I understand what you mean?

If you don't have a notification client, then you shouldn't be adding a NotificationController as a supplement to the Page. So I think you should be able to check for a null NotificationController, rather than  checking for a null NotificationClient.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list