[Webkit-unassigned] [Bug 109061] <link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 17:53:55 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109061





--- Comment #9 from Ruslan Abdikeev <aruslan at chromium.org>  2013-02-06 17:56:02 PST ---
(In reply to comment #8)
> We should rename iconURLs to shortcutIconURLs and leave it's behavior as-is.  If you need to get at the apple-touch-icons for whatever reason, they can be in a different accessor.
> You could also refactor the current accessor to take an IconType parameter and leverage that for code reuse between the current behavior and the new behavior you hope to add.

Agreed; I'm going to rename existing iconURLs() to shortcutIconURLs() keeping its semantics and add iconURLs(int iconTypes) that accepts a bitmask of IconTypes.
Additionally, I'll extend Internals.idl, fix tests and surrounding call-sites.

Are these names and parameters fine by you?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list