[Webkit-unassigned] [Bug 109065] [v8] move persistent::new and ::dispose into same class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 13:04:18 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=109065





--- Comment #6 from Adam Barth <abarth at webkit.org>  2013-02-06 13:06:25 PST ---
(From update of attachment 186875)
View in context: https://bugs.webkit.org/attachment.cgi?id=186875&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3545
> -    v8::Persistent<v8::Object> wrapperHandle = V8DOMWrapper::associateObjectWithWrapper(impl, &info, wrapper, isolate);
> -    if (!hasDependentLifetime)
> -        wrapperHandle.MarkIndependent();
> +    V8DOMWrapper::associateObjectWithWrapper(impl, &info, wrapper, isolate, hasDependentLifetime);

I see.  We used to do it here.  Maybe we should use an enum instead of a boolean parameter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list