[Webkit-unassigned] [Bug 108983] webkit-patch upload regenerates the WebCore ChangeLog every time it's called

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 07:34:49 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=108983





--- Comment #6 from Julien Chaffraix <jchaffraix at webkit.org>  2013-02-06 07:36:56 PST ---
> Did you manually remove "(WebCore):" and "(RenderBox):" from the list, because if so, this is *technically* a feature (albeit an annoying one), and we can work out some heuristics to allow this behaviour to pass (maybe allow users to delete (\w*): from .cpp and .h files).

Good point, I indeed removed the namespace / empty class entries as I find that they don't add anything to the ChangeLog. I also usually advise people in reviews to do the same.

If we fix this, this would probably solve my pain point with dealing with webkit-patch upload. Though there is still the possibility of shooting yourself in the foot that would need to be solved. A (really bad) idea would be to add some OOPS so that the commit hook can detect duplicated entries.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list