[Webkit-unassigned] [Bug 109011] File upload control doesn't apply CSS vertical padding or border to file name

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 00:00:10 PST 2013


--- Comment #5 from Nils Barth <nbarth at google.com>  2013-02-06 00:02:17 PST ---
(In reply to comment #2)
> (From update of attachment 186769 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186769&action=review
> We need a test.
> I think we can't make a dumpAsText test for this change.  Probably we need a ref test.

Ok, will do.

> > Source/WebCore/rendering/RenderFileUploadControl.cpp:142
> > +        LayoutUnit textY = paintOffset.y() + borderLeft() + paddingLeft() + buttonRenderer->baselinePosition(AlphabeticBaseline, true, HorizontalLine, PositionOnContainingLine);
> Why do you add border-left and padding-left to the vertical position?

Oops, fixed!
(I'd accidentally committed the change to master, so I just re-created it manually and accidentally switched left/top; didn't notice in testing b/c same.)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list