[Webkit-unassigned] [Bug 106669] [Qt] Switch to GStreamer 1.0

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106669


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #182351|review?                     |review+
               Flag|                            |




--- Comment #6 from Csaba Osztrogonac <ossy at webkit.org>  2013-02-05 07:22:36 PST ---
(From update of attachment 182351)
View in context: https://bugs.webkit.org/attachment.cgi?id=182351&action=review

r=me with minor changes mentioned inline, but we should wait with landing until bots upgrade.

>> Source/WebCore/ChangeLog:9
>> +	Switch to GStreamer 1.0.
> 
> Line contains tab character.  [whitespace/tab] [5]

Please remove this line.

>> Source/WebCore/WebCore.pri:169
>> +    DEFINES += GST_API_VERSION=1.0
> 
> That one is not needed I think.

I agree, we don't need it.

>> Tools/ChangeLog:9
>> +	Switch to GStreamer 1.0.
> 
> Line contains tab character.  [whitespace/tab] [5]

Please remove this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.