[Webkit-unassigned] [Bug 107829] Web Inspector: support JavaScript variable mutation in protocol and V8 bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107829


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186491|review?                     |review-
               Flag|                            |




--- Comment #16 from Pavel Feldman <pfeldman at chromium.org>  2013-02-05 02:02:05 PST ---
(From update of attachment 186491)
View in context: https://bugs.webkit.org/attachment.cgi?id=186491&action=review

Mac EWS claims inspector-protocol/debugger-setVariableValue.html [ Failure ] is failing. Otherwise looks good.

> Source/WebCore/bindings/v8/DebuggerScript.js:99
> +    if (!mirror.isFunction()) {

no {} around single line blocks.

> Source/WebCore/bindings/v8/DebuggerScript.js:108
> +    if (!scopeMirror) {

ditto

> Source/WebCore/bindings/v8/JavaScriptCallFrame.cpp:142
> +        deprecatedV8String(variableName),

What is deprecatedV8String ?

> Source/WebCore/inspector/InjectedScript.cpp:146
> +    // Normal return.

WebKit discourages comments.

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:602
> +    String newValueStr = newValue->toJSONString();

netValueString (no abbreviations in WebKit). Why don't you pass it as RefPtr?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.