[Webkit-unassigned] [Bug 108884] New: NRWT: confusing warning about a line being in a Skipped file when it is really just listed in _missing_symbol_to_skipped_tests in base.py

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108884

           Summary: NRWT: confusing warning about a line being in a
                    Skipped file when it is really just listed in
                    _missing_symbol_to_skipped_tests in base.py
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jberlin at webkit.org
                CC: eric at webkit.org, dpranke at chromium.org,
                    timothy_horton at apple.com


When running run-webkit-tests, I am seeing the following warnings:

LayoutTests/platform/mac/TestExpectations:1033 /Volumes/Users/jessieberlin/Source/Safari/Opensource/LayoutTests/platform/mac/TestExpectations:1033 fast/css/variables is also in a Skipped file. fast/css/variables
LayoutTests/platform/mac/TestExpectations:1034 /Volumes/Users/jessieberlin/Source/Safari/Opensource/LayoutTests/platform/mac/TestExpectations:1034 inspector/styles/variables is also in a Skipped file. inspector/styles/variables

This is happening because ‘fast/css/variables’ and ‘inspector/styles/variables’ are listed in _missing_symbol_to_skipped_tests as well as being listed in that TestExpectations file.

    # Ports which use compile-time feature detection should define this method and return                                                                                                                                             
    # a dictionary mapping from symbol substrings to possibly disabled test directories.                                                                                                                                              
    # When the symbol substrings are not matched, the directories will be skipped.                                                                                                                                                    
    # If ports don't ever enable certain features, then those directories can just be                                                                                                                                                 
    # in the Skipped list instead of compile-time-checked here.                                                                                                                                                                       
    def _missing_symbol_to_skipped_tests(self):
        """Return the supported feature dictionary. The keys are symbol-substrings                                                                                                                                                    
        and the values are the lists of directories to skip if that symbol is missing."""
        return {
            "MathMLElement": ["mathml"],
            "GraphicsLayer": ["compositing"],
            "WebCoreHas3DRendering": ["animations/3d", "transforms/3d"],
            "WebGLShader": ["fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "webgl"],
            "MHTMLArchive": ["mhtml"],
            "CSSVariableValue": ["fast/css/variables", "inspector/styles/variables"],
        }

I talked with Eric Seidel and Dirk Pranke about this on IRC. We should just remove this code. ORWT used to detect if you had SVG compiled into your binary and auto-skip relevant tests, and this was added to support that. Dirk also noted "there's a separate similar code path for "runtime" feature detection that IIRC was only needed for the apple win port and probably never really worked right there, either."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.