[Webkit-unassigned] [Bug 108818] [v8] explicit isolate parameter for MakeWeak calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108818


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186357|review?                     |review+
               Flag|                            |




--- Comment #2 from Kentaro Hara <haraken at chromium.org>  2013-02-04 05:40:41 PST ---
(From update of attachment 186357)
View in context: https://bugs.webkit.org/attachment.cgi?id=186357&action=review

> Source/WebCore/bindings/v8/DOMDataStore.cpp:43
> +    , m_wrapperMap(v8::Isolate::GetCurrent()) // TODO Don't call GetCurrent twice.

TODO =>　FIXME

> Source/WebCore/bindings/v8/DOMWrapperMap.h:108
> +    v8::NearDeathCallback m_callback;

NearDeathCallback is a good name!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.