[Webkit-unassigned] [Bug 108799] [CPP, GObj, ObjC] Add checks for unsupported Web IDL features, remove #if V8/JS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108799





--- Comment #3 from Kentaro Hara <haraken at chromium.org>  2013-02-04 03:41:39 PST ---
(From update of attachment 186336)
View in context: https://bugs.webkit.org/attachment.cgi?id=186336&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorCPP.pm:189
> +    if ($codeGenerator->GetArrayType($type)) {
> +        return 1;
> +    }
> +
> +    if ($codeGenerator->GetSequenceType($type)) {
> +        return 1;
> +    }

Are all array types and sequence types not supported in CodeGeneratorCPP? (not only DOMStringList and DOMString[])

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:260
> +    if ($codeGenerator->GetArrayType($functionReturnType)) {
> +        return 1;
> +    }

Ditto. Also, what about $codeGenerator->GetSequenceType() ?

> Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:438
> +    return 1 if $codeGenerator->GetSequenceType($type);
> +    return 1 if $codeGenerator->GetArrayType($type);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.