[Webkit-unassigned] [Bug 108799] New: [CPP, GObj, ObjC] Add checks for unsupported Web IDL features, remove #if V8/JS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 00:08:46 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=108799

           Summary: [CPP,GObj,ObjC] Add checks for unsupported Web IDL
                    features, remove #if V8/JS
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: nbarth at google.com
                CC: haraken at chromium.org


Currently IDLs (as in TestObj.idl) need to have an #if V8/JS around Web IDL features that aren't supported in [CPP,GObj,ObjC].
This patch adds checks in the code generators CodeGenerator{CPP,GObj,ObjC}.pm so these automatically skip these, avoiding generating incorrect code and allowing the IDL file itself to be clean.
It also removes a spurious check on a feature that actually is supported, and rebases tests to fix two mistakes in current test results.

Concretely, this adds the following checks:
1. Skip “Callback” extended attribute on operations

2. Remove #if around “CachedAttribute” extended attribute on attributes, as already supported, and rebase to add to tests:
./Source/WebCore/page/History.idl
./Source/WebCore/dom/MessageEvent.idl
./Source/WebCore/bindings/scripts/test/TestSerializedScriptValueInterface.idl

3. Skip overloaded operations, and rebase to remove accidentally included overloaded operation
CPP, GObject, ObjC manifestly don’t support overloads -- they don't call the LinkOverloadedFunctions function from CodeGenerator.pm -- but in TestObj.idl the overloadedMethod1 operation incorrectly isn't in an #if (unlike overloadedMethod, which was), so need to rebase.

4. Skip “DOMStringList” return type

5. [GObj] Skip array return type (to handle DOMString[])
Just missing check (has check for array in attributes, but not function return).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list