[Webkit-unassigned] [Bug 108788] Don't update author info in PrepareChangeLog and allow users to skip the PrepareChangeLog step entirely.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108788





--- Comment #3 from Timothy Loh <timloh at chromium.org>  2013-02-03 21:53:46 PST ---
(In reply to comment #2)
> (From update of attachment 186300 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186300&action=review
> 
> > Tools/Scripts/webkitpy/tool/steps/preparechangelog.py:87
> > -        new_date_line = new_entry.date_line()
> > -        old_date_line = old_entry.date_line()
> > -        if new_date_line != old_date_line:
> > -            final_entry = final_entry.replace(old_date_line, new_date_line)
> > +        final_entry = final_entry.replace(old_entry.date(), new_entry.date(), 1)
> 
> Why are we making this change? This patch needs per-function change log.

I'm not sure what you're asking here.

> > Tools/Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:99
> > +                      ((4, 0, 0, 0), (0, 0, 0, 0), (0, 0, 0, 0)),
> > +                      ((5, 0, 0, 0), (0, 0, 0, 0), (1, 0, 0, 0)),
> > +                      ((0, 0, 0, 0), (4, 0, 0, 0), (4, 0, 0, 0)),
> > +                      ((1, 0, 0, 0), (4, 0, 0, 0), (5, 0, 0, 0)),
> 
> What the heck is this mysterious matrix?

It looks a bit odd without context, but basically each 4-tuple represents a ChangeLog entry and each line is (new entry, old entry, expected result entry).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.