[Webkit-unassigned] [Bug 81103] [Texmap] Implement BGRA swizzling detection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 22:55:18 PST 2013


--- Comment #9 from Noam Rosenthal <noam at webkit.org>  2013-02-01 22:57:20 PST ---
(From update of attachment 186178)
View in context: https://bugs.webkit.org/attachment.cgi?id=186178&action=review

I remember this kind of patch had a tendency to break stuff :)
Can someone validate it on more than one GLES2 hardware?

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:591
>  #if defined(TEXMAP_OPENGL_ES_2)
> -    // FIXME: Implement reliable detection. See also https://bugs.webkit.org/show_bug.cgi?id=81103.
> -    return false;
> +    static bool supportsExternalTextureBGRA = context->getExtensions()->supports("GL_EXT_texture_format_BGRA8888");
> +    return supportsExternalTextureBGRA;
>  #else

I think we shoul switch here to isGLES2Compliant() instead of an #ifdef

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list