[Webkit-unassigned] [Bug 108678] [BlackBerry]Adjust fatfinger detection rect size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108678


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186116|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Antonio Gomes <tonikitoo at webkit.org>  2013-02-01 14:49:54 PST ---
(From update of attachment 186116)
View in context: https://bugs.webkit.org/attachment.cgi?id=186116&action=review

TJ: could you test one thing: instead of doing all this, could you not pass HitTestRequest::IgnoreClipping to requestType? and see if it helps

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:463
>      getPaddings(topPadding, rightPadding, bottomPadding, leftPadding);
>  
> +    // Do not allow fat fingers detect anything not visible(ie outside of the viewport)
> +    adjustPaddings(contentViewportPos, topPadding, rightPadding, bottomPadding, leftPadding);

not better to have a getAdjustedPaddings? (merge both methods)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.