[Webkit-unassigned] [Bug 108541] [chromium-android] disable all scrollbars except for the main frame

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 13:20:21 PST 2013


--- Comment #9 from Tien-Ren Chen <trchen at chromium.org>  2013-02-01 13:22:23 PST ---
(In reply to comment #8)
> (From update of attachment 186113 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=186113&action=review
> I don't understand why you feel the need to do this in such a hacky way.

Needing the compositor the recognize the main frame scrollbar and pass a magic flag to the theme sounds hacky too... I think these are 2 separate matter:

1. Should we introduce a new magic flag? Or reuse ScrollbarControlSize::SmallScrollbar is fine?
2. Who should be responsible for setting the flag? At creation time? Right after creation? Or the compositor?

I feel this is the least intrusive way to do the hack, hopefully we don't need to keep the hack for too long?

> > Source/WebCore/page/FrameView.cpp:526
> > +    if (m_frame = m_frame->page()->mainFrame())
> > +        return Scrollbar::createNativeScrollbar(this, orientation, RegularScrollbar);
> > +#endif
> Doesn't this also break custom scrollbars?  Why do you need to do that?

We disabled custom scrollbar anyway. I can switch the order to make custom scrollbar to work in case we want to enable it.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list