[Webkit-unassigned] [Bug 108088] [GStreamer] webkitwebsrc is exposed to application-side

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108088


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186028|review?                     |review-
               Flag|                            |




--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2013-02-01 09:01:28 PST ---
(From update of attachment 186028)
View in context: https://bugs.webkit.org/attachment.cgi?id=186028&action=review

Looks good, but I think it could use a teensy bit of cleanup.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:307
> +void MediaPlayerPrivateGStreamer::setPlaybinURL(KURL url)

This should likely accept a const KURL& url to avoid a copy.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:335
> +    // Clean out everything after file:// url path.
> +    if (kurl.isLocalFile())
> +        cleanUrl = cleanUrl.substring(0, kurl.pathEnd());

kurl.removeFragmentIdentifier() ? Probably better to put this into setPlaybinURL.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:579
> +    ASSERT(url.protocol().substring(0, 7) == "webkit+");
> +    url.setProtocol(url.protocol().substring(7));

You should probably make a getPlaybinURL method.

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:598
> -    static gchar* protocols[] = {(gchar*) "http", (gchar*) "https", 0 };
> +    static gchar* protocols[] = {(gchar*) "webkit+http", (gchar*) "webkit+https", 0 };

So do we even support file URLs? I'm pretty sure you don't need these casts here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.