[Webkit-unassigned] [Bug 108005] [GTK][WK2] MiniBrowser fullscreen signals support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108005


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #186002|review?                     |review-
               Flag|                            |




--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-02-01 04:06:12 PST ---
(From update of attachment 186002)
View in context: https://bugs.webkit.org/attachment.cgi?id=186002&action=review

Looks much better, there are still a few minor issues. You should also check in the window fialize if there's a hide message callback scheduled and remove the source in that case, otherwise the callback might be called with a window already destroyed.

> Tools/MiniBrowser/gtk/BrowserWindow.c:271
> +    gtk_widget_hide(fullScreenMessageLabel);

Here you still need to set the fullScreenMessageLabelId to 0 again, so pass the BrowserWindow instead of the label to the callback.

> Tools/MiniBrowser/gtk/BrowserWindow.c:279
> +    gchar *titleOrUri = webkit_web_view_get_title(window->webView);

This should be const, and the name titleOrURI

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.