[Webkit-unassigned] [Bug 126317] webkitdirs.pm does not use environment variable VSINSTALLDIR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126317





--- Comment #5 from David Delaune <david.delaune at hotmail.com>  2013-12-31 20:34:29 PST ---
Hey Brent,

Surely you remember me? I am the guy who worked and created the WinCairoRequirements Visual Studio project that you graciously uploaded to github.

(In reply to comment #4)
> It sounds like we have to execute the VSVARSALL.BAT script
> to (temporarily) set the VSINSTALLDIR environment variable.
> I don't see how executing this script as part of our build
> process is any better than coding the path to the required
> Visual Studio installation.


How is it even possible that you are not understanding this? The patch hard codes the path to Visual Studio to either the OS drive or the C drive. If Visual Studio is installed anywhere else they will be unable to build.


> 
> We could certainly manually create a VSINSTALLDIR environment
> variable, but I'm not sure what problem we are solving by doing so.


The VSVARSALL.BAT script batch file sets several environment variables, PATH, INCLUDE, LIB and LIBPATH. It also adds the path to Windows SDK and corresponding toolsets.


> 
> Can you be specific about the issue you are actually having?
> 


Unable to compile without fixing webkitdirs.pm library.


> * Are you trying to build with something besides VS3013?


I am obviously compiling with Visual Studio 2013 (Version 12)

> * Did you install VS2013 in an unusual location and are having
> a problem? If so, what errors are you seeing?


Define unusual. My workstation has Visual Studio 2013 installed on the D: drive. The operating system is on the C: drive. I mention this in the first comment. I find it disturbing that you do not know what errors occur when the build script cannot find the compiler. I am beginning to wonder if you are being pretensive.

> 
> I work with several other Windows developers, who had no problem with this change. Please provide specific error messages and build logs so we can deal with the actual problem you are encountering.

They would certainly be able to compile if Visual Studio installed on either the C: drive or OS drive.

Best Wishes,
-David Delaune

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.