[Webkit-unassigned] [Bug 126285] XML document builder should create render tree asynchronously

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126285


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #220101|review?                     |review+
               Flag|                            |




--- Comment #3 from Andreas Kling <akling at apple.com>  2013-12-30 05:54:40 PST ---
(From update of attachment 220101)
View in context: https://bugs.webkit.org/attachment.cgi?id=220101&action=review

r=me

> Source/WebCore/ChangeLog:19
> +            recalc don't start creating new renderers.

doesn't

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:-1035
>      RefPtr<CDATASection> newNode = CDATASection::create(m_currentNode->document(), toString(s, len));
>      m_currentNode->parserAppendChild(newNode.get());
> -    if (m_view)
> -        Style::attachTextRenderer(*newNode);

We don't need to keep 'newNode' valid after appending it anymore, should make it:
m_currentNode->parserAppendChild(newNode.release());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.