[Webkit-unassigned] [Bug 126258] Crash when starting a download before the network process has been launched

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126258





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-12-27 01:35:02 PST ---
(In reply to comment #2)
> (From update of attachment 220054 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220054&action=review
> 
> Good job!
> 
> > Source/WebKit2/UIProcess/WebContext.cpp:766
> > +        networkProcess()->send(Messages::NetworkProcess::DownloadRequest(downloadProxy->downloadID(), request), 0);
> 
> I guess this is totally unrelated and just to keep consistency with the rest of the file

No, it's not, see the ChageLog.

"Use ChildProcessProxy::send() instead of using the connection to make sure messages are queued"

> > Source/WebKit2/UIProcess/WebContext.cpp:946
> >  #endif
> 
> Looks correct. I understand that this might be difficult to reproduce in real life situations (as a webprocess should have been spawned and a networkprocess with it) but easily in the unit tests.

It's difficult to happen in a web browser, yes, but our API allows to start a download from a WebContext without any web page involved.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.