[Webkit-unassigned] [Bug 98931] [GTK] Add touch support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98931





--- Comment #13 from Martin Robinson <mrobinson at webkit.org>  2013-12-23 18:18:41 PST ---
(From update of attachment 219947)
View in context: https://bugs.webkit.org/attachment.cgi?id=219947&action=review

>>> Source/WebCore/PlatformGTK.cmake:631
>>> +
>> 
>> We are enabling touch events unconditionally for GTK+ and this conditional isn't mirrored in the autotools version of the build, so I think it makes sense to unconditionally add the file to the list here as well.
>> 
>> Thank you very kindly for updating the CMake build!
> 
> hmm, Isn't that done on the change to Source/autotools/SetupWebKitFeatures.m4? or should I be doing that somewhere else?

I only meant that you shouldn't need to check for ENABLE_TOUCH_EVENTS since we are turning it on always. That does remind me that you should change the setting in Source/cmake/OptionsGTK.cmake as well though.

>>> Source/WebKit2/Shared/gtk/WebEventFactory.cpp:207
>>> +#ifndef GTK_API_VERSION_2
>> 
>> No need for this check here, since WebKit2 is only available for GTK+ 3 builds.
> 
> Isn't that code used on the webprocess? I got errors when compiling otherwise, from what I checked it was linking to gtk+2 at that time.

Ah! A few files are compiled into the plugin process as well, which does indeed compile against GTK+2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.