[Webkit-unassigned] [Bug 98931] [GTK] Add touch support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98931





--- Comment #10 from Carlos Garnacho <carlosg at gnome.org>  2013-12-23 17:19:42 PST ---
Thanks KaL for the comments! All style issues are fixed, I'm replying below to some things

(In reply to comment #7)
> > Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp:41
> > +    uint32_t sequence;
> > +
> > +    sequence = GPOINTER_TO_UINT (gdk_event_get_event_sequence (touchEvent));
> 
> This should be a single line. Why are we converting it to an integer?

Hmm well, GdkEventSequence is essentially a GINT_TO_POINTER(), and web touch events also prefer ints as IDs, I thought it made sense to do the same all through.

> > Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp:59
> > +Vector<GdkEvent*> GtkTouchContextHelper::getTouchEvents(void) const
> 
> For methods returning a value the name should be without the get, just GtkTouchContextHelper::touchEvents(). However, in this case we could leave the name and make the function receive a reference

I guess you mean a reference on the container? I kind of liked not having to copy GdkEvents around there :)

> > Source/WebKit2/Shared/gtk/WebEventFactory.cpp:277
> > +        touchPointList.uncheckedAppend(touchPoint);
> 
> This is mostly the same than previous block, we can probably make a helper function like appendTouchEvent(Vector<WebPlatformTouchPoint>&, GdkEvent*, WebPlatformTouchPoint::TouchPointState);

Indeed, refactored that out in my last patch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.