[Webkit-unassigned] [Bug 98931] [GTK] Add touch support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98931





--- Comment #4 from WebKit Commit Bot <commit-queue at webkit.org>  2013-12-23 08:37:39 PST ---
Attachment 219912 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/PlatformGTK.cmake', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp', u'Source/WebCore/platform/gtk/GtkTouchContextHelper.h', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.list.am', u'Source/WebKit2/PlatformGTK.cmake', u'Source/WebKit2/Shared/NativeWebTouchEvent.h', u'Source/WebKit2/Shared/gtk/NativeWebTouchEventGtk.cpp', u'Source/WebKit2/Shared/gtk/WebEventFactory.cpp', u'Source/WebKit2/Shared/gtk/WebEventFactory.h', u'Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp', u'Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp', u'Source/autotools/SetupWebKitFeatures.m4', u'Source/cmake/OptionsGTK.cmake', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp:41:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/gtk/GtkTouchContextHelper.cpp:54:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:211:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:212:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:218:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:244:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:252:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:258:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:260:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:261:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:267:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:273:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:276:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:281:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/Shared/gtk/WebEventFactory.cpp:282:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:342:  Declaration has space between type name and * in const GdkEvent *touch_event  [whitespace/declaration] [3]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:347:  Declaration has space between type name and * in GdkEvent *pointer_event  [whitespace/declaration] [3]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:350:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:359:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:361:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:365:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:374:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:377:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:378:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:379:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebKit2/Shared/NativeWebTouchEvent.h:53:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/ChangeLog:11:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:727:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 31 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.