[Webkit-unassigned] [Bug 123458] [GTK] Put cache files in XDG_CACHE_HOME

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123458


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219740|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2013-12-20 11:13:25 PST ---
(From update of attachment 219740)
View in context: https://bugs.webkit.org/attachment.cgi?id=219740&action=review

Looks good, but a few small suggestions before landing this. You can just upload a new version with the Reviewed by line filled in and then I can commit it with the commit queue.

> Source/WebKit/gtk/ChangeLog:3
> +        https://bugs.webkit.org/show_bug.cgi?id=123458

This changelog is missing a newline.

> Source/WebKit2/ChangeLog:3
> +        [GTK] Put cache files in XDG_CACHE_HOME
> +        https://bugs.webkit.org/show_bug.cgi?id=123458

This one too.

> Tools/GtkLauncher/main.c:242
> -    iconDatabasePath = g_build_filename(g_get_user_data_dir(), "webkit", "icondatabase", NULL);
> +    iconDatabasePath = g_build_filename(g_get_user_cache_dir(), "webkit", "icondatabase", NULL);

It's probably a good moment to actually put this into a GtkLauncher subdirectory instead of "webkit"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.