[Webkit-unassigned] [Bug 126057] Clearing 'dir' attribute does not correctly set page directionality

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126057


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219738|review?                     |review-
               Flag|                            |




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2013-12-20 09:06:47 PST ---
(From update of attachment 219738)
View in context: https://bugs.webkit.org/attachment.cgi?id=219738&action=review

> Source/WebCore/html/HTMLElement.cpp:209
> +            AtomicString dirValue = isValidDirAttribute(value) ? value : "ltr";

This is incorrect. When dir="" attribute doesn't parse correctly, it needs to be treated as if it doesn't exist for the purpose of determining the directionality of text.
I've specifically added a test case for this in fast/dom/HTMLElement/set-and-clear-dir-attribute.html

i.e. the blink change is wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.