[Webkit-unassigned] [Bug 125993] [GTK] The fullscreen API should be enabled by default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125993


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219741|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Gustavo Noronha (kov) <gns at gnome.org>  2013-12-20 03:35:36 PST ---
(From update of attachment 219741)
View in context: https://bugs.webkit.org/attachment.cgi?id=219741&action=review

It sounds good to me, have this been discussed with Carlos, Phillippe or Martin? =)

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:834
> +            _("Whether the Mozilla style API should be enabled."),

Mozilla style? This should say the same thing as the other one, and have a Since of 2.4 I believe. Would be good to have the gtk-doc documentation header added here, I think.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:907
> +            _("Whether to enable the Javascriipt Fullscreen API"),

Javascript has 2 i's here, let's fix that too =)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.