[Webkit-unassigned] [Bug 83045] Improve line breaking performance for complex text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83045


Dominik Röttsches (drott) <dominik.rottsches at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dominik.rottsches at intel.com




--- Comment #30 from Dominik Röttsches (drott) <dominik.rottsches at intel.com>  2013-12-19 03:31:14 PST ---
(In reply to comment #0)
> Profiling on Mac and iOS has shown that measuring complex text by creating a ComplexTextController for each word is suboptimal. This patch addresses this for RenderBlock::LineBreaker::nextLineBreak by creating and reusing a ComplexTextController per RenderText. Benchmarks using a simple test app show a 35% improvement when laying out a paragraph of English text with optimizeLegibility.

Ned, could you publish that test app or give some details on how you measured? Was it a web page based benchmark? Or a native app that links against some of the line layout code and tested that with some demo strings?

I am looking at this code in Blink now and it looks like the optimization is not as effective any more - when setting the TextLayout to nullptr and running the old path is actually now faster for example for Arabic line layout - but I'd like to get better data.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.