[Webkit-unassigned] [Bug 125924] Null-pointer dereference in WebCore::RootInlineBox::prevRootBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125924


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219529|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-12-18 06:27:29 PST ---
(From update of attachment 219529)
View in context: https://bugs.webkit.org/attachment.cgi?id=219529&action=review

Code change looks fine, but we need to remove the "nobreak" comment.

> LayoutTests/ChangeLog:3
> +        Null-pointer dereference in WebCore::RootInlineBox::prevRootBox

This is a bad bug/patch title and we should avoid them. It describes the symptom and not the cause.
I would call it something like "CSS: Null-pointer dereference with negative 'orphans' value."

> Source/WebCore/css/CSSParser.cpp:2225
>          /* nobreak */

This idiosyncratic comment is no longer valid since you're removing the fall-through.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.