[Webkit-unassigned] [Bug 125857] [ATK] Expose accessibility objects for <dl>, <dt> and <dd>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125857





--- Comment #3 from Mario Sanchez Prada <mario at webkit.org>  2013-12-17 09:49:34 PST ---
(In reply to comment #2)
> (From update of attachment 219420 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219420&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:638
> > +        if (coreObject->isList() && toAccessibilityList(coreObject)->isDescriptionList())
> 
> It might be better to introduce a new WebCore role for DescriptionList, but I don't feel that strongly about it

There is a DescriptionListRole already, which in theory should get assigned to any object with the <dl> tag name in determineAccessibilityRole(). Problem is that there is a hardcoded rule in AXObjectCache::createFromRenderer() that creates an instance of AccessibilityList for those elements too:

static PassRefPtr<AccessibilityObject> createFromRenderer(RenderObject* renderer)
{
    // FIXME: How could renderer->node() ever not be an Element?
    Node* node = renderer->node();

    // If the node is aria role="list" or the aria role is empty and its a
    // ul/ol/dl type (it shouldn't be a list if aria says otherwise).
    if (node && ((nodeHasRole(node, "list") || nodeHasRole(node, "directory"))
                      || (nodeHasRole(node, nullAtom) && (node->hasTagName(ulTag) || node->hasTagName(olTag) || node->hasTagName(dlTag)))))
        return AccessibilityList::create(renderer);
   [...]
}

I thought of updating Accessibility::roleValue() to do this isDescriptionList() check and return ListRole or DescriptionListRole accordingly, but I discarded because I was not sure about which things that might break in the Mac, and also because I saw in the Mac wrapper that DescriptionListRole is used in the Mac as a subrole, not a main role, so I was not sure at all about removing the ListRole thing from there.

So, in the end, I went for doing that check in the ATK wrapper, but I'm open to reconsider other options if you think they're feasible.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.