[Webkit-unassigned] [Bug 124866] VS2010 doesn't like std::make_unique

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124866





--- Comment #8 from Darin Adler <darin at apple.com>  2013-12-17 09:14:14 PST ---
(From update of attachment 219386)
View in context: https://bugs.webkit.org/attachment.cgi?id=219386&action=review

>> Source/WebCore/platform/graphics/TiledBackingStore.h:44
>> +    TiledBackingStore(TiledBackingStoreClient*, std::unique_ptr<TiledBackingStoreBackend> = std::unique_ptr<TiledBackingStoreBackend>(new TiledBackingStoreBackend()));
> 
> Please don’t do this. Is there some other solution? The reason we use make_unique is so that we can search the entire project for "new" to find mistakes. We really don’t want to do this just to accommodate a broken compiler.
> 
> I suggest we use overloading instead:
> 
>     TiledBackingStore(TiledBackingStoreClient*);
>     TiledBackingStore(TiledBackingStoreClient*, std::unique_ptr<TiledBackingStoreBackend>);
> 
> Then the make_unique can go into the TiledBackingStore.cpp file. I’m hoping we can get it to compile there.
> 
> By the way, this overloading also makes it clear that the single-non-default-argument constructor needs “explicit” added to it. Please do that.

I see now that Sam suggested the same thing, but for some reason you did not do what he suggested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.