[Webkit-unassigned] [Bug 125854] [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125854


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219413|                            |review?
               Flag|                            |




--- Comment #2 from Mario Sanchez Prada <mario at webkit.org>  2013-12-17 05:56:04 PST ---
Created an attachment (id=219413)
 --> (https://bugs.webkit.org/attachment.cgi?id=219413&action=review)
Patch proposal

Patch attached. As you can see, the main change is this bit in DRT:

 JSObjectRef AccessibilityUIElement::makeJSAccessibilityUIElement(JSContextRef context, const AccessibilityUIElement& element)
 {
+    if (!element.platformUIElement())
+        return nullptr;
+
     return JSObjectMake(context, AccessibilityUIElement::getJSClass(), new AccessibilityUIElement(element));
 }

I understand that should be ok for the Mac too (for other platforms, PlatformUIElement is a pointer, so I assume it will be ok), but would be great to confirm that.

Also, I slightly modified two tests more (besides roles-exposed.html) to be able to test the same things while avoiding the differences in the accessibility hierarchy compared to ATK based ports. Hope that's fine as well.

Please review, thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.